Update OffCanvas component's more menu to get clientId from block rather than passed in as prop #50473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
draganescu
changed the title
draganescu
changed the title
|
Size Change: +3 B (0%) Total Size: 1.38 MB
ℹ️ View Unchanged
|
MaggieCabrera
approved these changes
May 9, 2023
|
Flaky tests detected in 96151df. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4927521857
|
jeryj
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
In the OffCanvas component this PR uodates the more menu of the block leaf to extract the
clientIdfrom the currentblockleaf, instead of having to pass theclientIdas a prop to the more menu.Why?
We are removing
<OffCanvasEditor />, and this change is necessary for several of the PRs that are part of this work. This shouldn't change the functionality of anything, but is a necessary change to move several PRs forwards so it made sense to merge it to trunk and rebase the other PRs, like:Testing Instructions
There should be no functional changes to anything. Purely a refactor.